This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove TransientValidationData #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a big change since this type is not used anywhere
Also update the guide
pepyakin
added
A0-please_review
coriolinus
approved these changes
Jan 15, 2021
rphmeier
approved these changes
Jan 18, 2021
bkchr
pushed a commit
that referenced
this pull request
Jan 26, 2021
* collation-generation: use persisted validation data * node: remote FullValidationData API * runtime: remove FullValidationData API * backing tests: use persisted validation data * FullCandidateReceipt: use persisted validation data This is not a big change since this type is not used anywhere * Remove ValidationData and TransientValidationData Also update the guide
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After paritytech/cumulus#279 we don't need transient validation data for anything important (those use cases are replaced by the merkle proofs of the relay chain storage). This PR removes it.
I recommend reviewing this PR by checking the commits individually.
Related #2244
Closes #2085